Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: rebase-release-4.18-4.18.0-0.nightly-2025-01-23-202230_amd64-2025-01-23_arm64-2025-01-24 #4461

Merged
merged 5 commits into from
Jan 24, 2025
Merged

NO-ISSUE: rebase-release-4.18-4.18.0-0.nightly-2025-01-23-202230_amd64-2025-01-23_arm64-2025-01-24 #4461

merged 5 commits into from
Jan 24, 2025

Conversation

microshift-rebase-script[bot]
Copy link
Contributor

amd64: 4.18.0-0.nightly-2025-01-23-202230
arm64: 4.18.0-0.nightly-arm64-2025-01-24-001340
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.18-rebase-on-nightlies/1882639803996966912

  • api embedded-component 29859d55727bb0b6294838e93898424ac57e4c04 to 55c9ecba501fbe31f5e0a6613f30cff76039a10e

    • d258c1e 2025-01-16T14:15:07+00:00 Regenerate CRDs for new StaticPodOperatorStatus validation.
    • 336bee7 2025-01-16T14:15:07+00:00 Forbid downgrades and concurrent rollouts StaticPodOperatorStatus.

  • cluster-csi-snapshot-controller-operator embedded-component 42ed4cc366a40c28b22e0aea02ba8075dc2831eb to 46902b494ed0a608a48d2a04faf6e4ed2f9a6a5b

    • 95b72be 2025-01-13T16:32:54+00:00 Add missing WithSyncDegradedOnError errors
    • 9bdf8ba 2025-01-13T16:32:54+00:00 Fix rbac roles to allow removal of deployment, pdb and services
    • 513fd36 2025-01-13T16:32:54+00:00 Drop feature-gate change from openshift/api
    • 5edd568 2025-01-13T16:32:54+00:00 Add code for removing webhook controller and stuff
    • e08ee29 2025-01-13T16:32:54+00:00 Bring back webbook resources for now
    • fbe602a 2025-01-13T16:32:54+00:00 Bring latest version of CRDs
    • b2bbdbb 2025-01-13T16:32:54+00:00 Remove rbac files from assets
    • 99a196a 2025-01-13T16:32:54+00:00 Patch rbac rules as per upstream requirements
    • 0f6f1c0 2025-01-13T16:32:54+00:00 Copy the v1beta1 CRDs from code
    • 4d3374e 2025-01-13T16:32:54+00:00 Remove clusterbindings for webhook
    • 70bc73d 2025-01-13T16:32:54+00:00 Remove all of the code related to installation of webhook
    • b4c8794 2025-01-13T16:32:54+00:00 Change external-snapshotter to use featuregate for volumegroupSnapshot
    • f21708b 2025-01-13T16:32:54+00:00 Bump API from forked version to make featuregate GA

  • csi-external-snapshotter embedded-component f52ce8b8b0799a341caf1fb864bba5d9d040a856 to 838d2484157f076bbb81f1b584898aec6f051c2f

The change list was truncated. See scripts/auto-rebase/changelog.txt in the PR for the full details.

/label tide/merge-method-squash
/label cherry-pick-approved
/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci-robot
Copy link

@microshift-rebase-script[bot]: This pull request explicitly references no jira issue.

In response to this:

amd64: 4.18.0-0.nightly-2025-01-23-202230
arm64: 4.18.0-0.nightly-arm64-2025-01-24-001340
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.18-rebase-on-nightlies/1882639803996966912

  • api embedded-component 29859d55727bb0b6294838e93898424ac57e4c04 to 55c9ecba501fbe31f5e0a6613f30cff76039a10e

  • d258c1e 2025-01-16T14:15:07+00:00 Regenerate CRDs for new StaticPodOperatorStatus validation.

  • 336bee7 2025-01-16T14:15:07+00:00 Forbid downgrades and concurrent rollouts StaticPodOperatorStatus.

  • cluster-csi-snapshot-controller-operator embedded-component 42ed4cc366a40c28b22e0aea02ba8075dc2831eb to 46902b494ed0a608a48d2a04faf6e4ed2f9a6a5b

  • 95b72be 2025-01-13T16:32:54+00:00 Add missing WithSyncDegradedOnError errors

  • 9bdf8ba 2025-01-13T16:32:54+00:00 Fix rbac roles to allow removal of deployment, pdb and services

  • 513fd36 2025-01-13T16:32:54+00:00 Drop feature-gate change from openshift/api

  • 5edd568 2025-01-13T16:32:54+00:00 Add code for removing webhook controller and stuff

  • e08ee29 2025-01-13T16:32:54+00:00 Bring back webbook resources for now

  • fbe602a 2025-01-13T16:32:54+00:00 Bring latest version of CRDs

  • b2bbdbb 2025-01-13T16:32:54+00:00 Remove rbac files from assets

  • 99a196a 2025-01-13T16:32:54+00:00 Patch rbac rules as per upstream requirements

  • 0f6f1c0 2025-01-13T16:32:54+00:00 Copy the v1beta1 CRDs from code

  • 4d3374e 2025-01-13T16:32:54+00:00 Remove clusterbindings for webhook

  • 70bc73d 2025-01-13T16:32:54+00:00 Remove all of the code related to installation of webhook

  • b4c8794 2025-01-13T16:32:54+00:00 Change external-snapshotter to use featuregate for volumegroupSnapshot

  • f21708b 2025-01-13T16:32:54+00:00 Bump API from forked version to make featuregate GA

  • csi-external-snapshotter embedded-component f52ce8b8b0799a341caf1fb864bba5d9d040a856 to 838d2484157f076bbb81f1b584898aec6f051c2f

  • 2e23d4b 2025-01-22T08:52:28+00:00 UPSTREAM: : Updating ose-csi-snapshot-controller-container image to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/b163b67a10ddfe91db1d3beae44531ecb997b57f/images/ose-csi-snapshot-controller.yml

  • 63bb241 2025-01-22T08:34:52+00:00 UPSTREAM: : Updating ose-csi-snapshot-validation-webhook-container image to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/b163b67a10ddfe91db1d3beae44531ecb997b57f/images/csi-snapshot-validation-webhook.yml

  • 54a62c0 2025-01-22T08:04:26+00:00 UPSTREAM: : Updating ose-csi-external-snapshotter-container image to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/b163b67a10ddfe91db1d3beae44531ecb997b57f/images/ose-csi-external-snapshotter.yml

  • c6b6037 2025-01-13T12:48:28-05:00 UPSTREAM: : Downgrade golang version

  • 6ff7745 2024-12-10T16:56:25-05:00 UPSTREAM: : ship webhook image with snapshot-controller

  • a1074f5 2024-12-10T15:11:20+05:30 Add nil check for groupSnapshotContent in deleteCSIGroupSnapshotOperation and unit tests

  • a992258 2024-12-09T20:59:28-05:00 Add release notes for v8.2.0

  • 965e259 2024-12-09T20:33:36+00:00 wip: Snapshot Controller startup should not LIST all volumesnapshots

  • 370225d 2024-12-09T19:30:08+00:00 Update the API Approved Annotation

  • cb86a44 2024-12-09T11:18:56+00:00 Change CreationTime in VolumeGroupSnapshotContentStatus from *int64 to *metav1.Time

  • ab1c827 2024-12-05T09:54:44+00:00 UPSTREAM: : Updating ose-csi-snapshot-controller-container image to be consistent with ART for 4.19 Reconciling with https://github.com/openshift/ocp-build-data/tree/a39508c86497b4e5e463d7b2c78e51e577be9e7d/images/ose-csi-snapshot-controller.yml

  • 52f291b 2024-12-05T04:39:52+00:00 UPSTREAM: : Updating ose-csi-snapshot-validation-webhook-container image to be consistent with ART for 4.19 Reconciling with https://github.com/openshift/ocp-build-data/tree/a39508c86497b4e5e463d7b2c78e51e577be9e7d/images/csi-snapshot-validation-webhook.yml

  • 34854a6 2024-12-04T08:04:10+01:00 Dont call DeleteSnapshot when VS belong to VGS

  • fc7ed96 2024-12-03T21:30:38+00:00 UPSTREAM: : Updating ose-csi-external-snapshotter-container image to be consistent with ART for 4.19 Reconciling with https://github.com/openshift/ocp-build-data/tree/2ea3e6158c93ca104b9d59fd58a71536fa01fb2d/images/ose-csi-external-snapshotter.yml

  • 7b6db9d 2024-12-03T13:34:41+01:00 replace deprecated Queue and RateLimiter

  • af1f842 2024-12-03T06:46:26+01:00 replace enable-volume-group-snapshots with featuregate

  • 2c63f95 2024-12-02T19:03:44+00:00 Improve VolumeSnapshotPairList comments

  • 42b9deb 2024-12-02T19:03:44+00:00 Improve VolumeGroupSnapshotStatus comments

  • 341ac4c 2024-12-02T19:03:44+00:00 Remove unused structures

  • 58bae80 2024-12-02T19:03:44+00:00 Remove v1alpha1 API

  • 57560c1 2024-12-02T19:03:44+00:00 Update VolumeGroupSnapshot to v1beta1

  • 79502ab 2024-12-02T17:46:24+00:00 Bump the k8s-dependencies group across 1 directory with 2 updates

  • c70f946 2024-12-02T16:51:25+00:00 Use ownership to identify volume group snapshot members

  • e42baeb 2024-12-02T13:01:59+00:00 Bump the github-dep

The change list was truncated. See scripts/auto-rebase/changelog.txt in the PR for the full details.

/label tide/merge-method-squash
/label cherry-pick-approved
/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2025
@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 24, 2025
@openshift-ci openshift-ci bot requested review from agullon and pacevedom January 24, 2025 04:22
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@microshift-rebase-script[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk
Copy link
Member

pmtk commented Jan 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: microshift-rebase-script[bot], pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7474208 into release-4.18 Jan 24, 2025
13 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the rebase-release-4.18-4.18.0-0.nightly-2025-01-23-202230_amd64-2025-01-23_arm64-2025-01-24 branch January 24, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agullon agullon Awaiting requested review from agullon

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openshift-ci-robot @pmtk