Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-5344: introduce ingress security customizations #4474

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

USHIFT-5344: introduce ingress security customizations #4474

wants to merge 6 commits into from

Conversation

eslutsky
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eslutsky
Copy link
Contributor Author

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@eslutsky eslutsky force-pushed the custom_ingress_cert branch from 11d428f to ff2474e Compare January 28, 2025 08:38
@eslutsky
Copy link
Contributor Author

/test all

@eslutsky eslutsky force-pushed the custom_ingress_cert branch 2 times, most recently from 18db32a to c8bffb1 Compare January 28, 2025 16:36
@eslutsky eslutsky changed the title remove unused ingress certificate fields USHIFT-5344: introduce ingress certificate fields Jan 28, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2025 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-5344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eslutsky eslutsky force-pushed the custom_ingress_cert branch from c8bffb1 to 1c7e595 Compare February 6, 2025 09:39
@eslutsky
Copy link
Contributor Author

eslutsky commented Feb 6, 2025

/test test-rebase

@eslutsky eslutsky force-pushed the custom_ingress_cert branch from 4115f13 to 2383485 Compare February 12, 2025 21:01
@eslutsky eslutsky force-pushed the custom_ingress_cert branch from 2383485 to f09ca13 Compare February 12, 2025 21:04
@eslutsky
Copy link
Contributor Author

/test all

1 similar comment
@eslutsky
Copy link
Contributor Author

/test all

@eslutsky eslutsky force-pushed the custom_ingress_cert branch from 95eb9ff to c0bd143 Compare February 13, 2025 14:49
@eslutsky
Copy link
Contributor Author

/test verify

@eslutsky
fix linter errors
72c9131 
Signed-off-by: Evgeny Slutsky <[email protected]>
@eslutsky eslutsky force-pushed the custom_ingress_cert branch from c0bd143 to 72c9131 Compare February 14, 2025 09:24
@eslutsky
Copy link
Contributor Author

/test verify

@eslutsky
Copy link
Contributor Author

/test all

@eslutsky eslutsky marked this pull request as ready for review February 17, 2025 15:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2025
@eslutsky eslutsky changed the title USHIFT-5344: introduce ingress certificate fields USHIFT-5344: introduce ingress certificate fields and tests Feb 17, 2025
@openshift-ci openshift-ci bot requested review from copejon and pmtk February 17, 2025 15:16
@eslutsky eslutsky force-pushed the custom_ingress_cert branch from 5954e9e to fe55e23 Compare February 18, 2025 09:41
@eslutsky eslutsky changed the title USHIFT-5344: introduce ingress certificate fields and tests USHIFT-5344: introduce ingress security customizations Feb 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@pmtk pmtk Awaiting requested review from pmtk

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eslutsky @openshift-ci-robot