Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] USHIFT-5294: Enable sigstore verification for selected scenarios #4478

Merged
merged 6 commits into from
Jan 30, 2025
Merged

[release-4.18] USHIFT-5294: Enable sigstore verification for selected scenarios #4478

merged 6 commits into from
Jan 30, 2025

Conversation

ggiguash
Copy link
Contributor

This is a manual cherry-pick of #4475.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2025 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-5294 which is a valid jira issue.

In response to this:

This is a manual cherry-pick of #4475.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@ggiguash
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor Author

Looks like a network failure. Reruning tests.
/retest-required

@pmtk
Copy link
Member

pmtk commented Jan 30, 2025

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member

pmtk commented Jan 30, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor Author

/label backport-risk-assessed
/label cherry-pick-approved
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 32e0a77 into openshift:release-4.18 Jan 30, 2025
13 checks passed
@ggiguash ggiguash deleted the enable_sigstore_verification_418 branch February 4, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pmtk