Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: rebase-release-4.18-4.18.0-0.nightly-2025-01-29-133231_amd64-2025-01-29_arm64-2025-01-29 #4493

Merged
merged 4 commits into from
Jan 30, 2025
Merged

NO-ISSUE: rebase-release-4.18-4.18.0-0.nightly-2025-01-29-133231_amd64-2025-01-29_arm64-2025-01-29 #4493

merged 4 commits into from
Jan 30, 2025

Conversation

microshift-rebase-script[bot]
Copy link
Contributor

amd64: 4.18.0-0.nightly-2025-01-29-133231
arm64: 4.18.0-0.nightly-arm64-2025-01-29-183712
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.18-rebase-on-nightlies/1884814036927778816

/label tide/merge-method-squash
/label cherry-pick-approved
/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2025
@openshift-ci-robot
Copy link

@microshift-rebase-script[bot]: This pull request explicitly references no jira issue.

In response to this:

amd64: 4.18.0-0.nightly-2025-01-29-133231
arm64: 4.18.0-0.nightly-arm64-2025-01-29-183712
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.18-rebase-on-nightlies/1884814036927778816

/label tide/merge-method-squash
/label cherry-pick-approved
/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 30, 2025
@openshift-ci openshift-ci bot requested review from eslutsky and vanhalenar January 30, 2025 04:24
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@microshift-rebase-script[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pacevedom
pacevedom approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: microshift-rebase-script[bot], pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 356dc9a into release-4.18 Jan 30, 2025
12 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the rebase-release-4.18-4.18.0-0.nightly-2025-01-29-133231_amd64-2025-01-29_arm64-2025-01-29 branch January 30, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom approved these changes

@eslutsky eslutsky Awaiting requested review from eslutsky

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openshift-ci-robot @pacevedom