USHIFT-5381: Check microshift.service for all healthchecks #4538
Conversation
|
@pmtk: This pull request references USHIFT-5381 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@pmtk , should we add a test for this in the |
pmtk
force-pushed
the
check-service-for-all-healthchecks
branch
from
4ce8bc9 to
858a6bf
Compare
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| [Setup] Disable MicroShift | ||
| ${before}= Get Current Date | ||
| ${stdout} ${stderr} ${rc}= SSHLibrary.Execute Command | ||
| ... /etc/greenboot/check/required.d/41_microshift_running_check_multus.sh |
There was a problem hiding this comment.
Should we do this for all the scripts in that directory except the main one?
| Should Contain ${stderr} microshift.service is not enabled | ||
| ${diff}= Subtract Date From Date ${after} ${before} | ||
| # Verify that the command returned very quickly - it didn't waste time trying to access API Server. | ||
| Should Be True ${diff} < 5 Multus healthcheck script took too long to finish |
There was a problem hiding this comment.
Why do we need the time check? Is getting the right error message not enough?
If microshift optional RPMs were installed, but microshift is not enabled, primary healthcheck will exit early without an error.
This doesn't hold for other healthchecks - there's no check if microshift.service is enabled, it just proceeds to querying the API server.
Result is that optional healthchecks fail greenboot even if MicroShift is disabled.