Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-5281: Implement brew configuration and package management procedures #4572

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

USHIFT-5281: Implement brew configuration and package management procedures #4572

wants to merge 8 commits into from

Conversation

ggiguash
Copy link
Contributor

The Prow counter-part of this change is in openshift/release#60995.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-5281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

The Prow counter-part of this change is in openshift/release#60995.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@ggiguash ggiguash force-pushed the brew_package_tests branch 7 times, most recently from 754c5bb to e6d5402 Compare February 18, 2025 17:57
pmtk
pmtk reviewed Feb 19, 2025
View reviewed changes
@ggiguash ggiguash marked this pull request as ready for review February 19, 2025 15:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@ggiguash
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@ggiguash
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@ggiguash: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-serial-rhel-eus

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-cache

pull-ci-openshift-microshift-main-e2e-aws-tests-cache-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-rpm

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash ggiguash marked this pull request as draft February 20, 2025 10:07
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache

1 similar comment
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

1 similar comment
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2025
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm

@ggiguash ggiguash marked this pull request as ready for review February 23, 2025 14:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2025
@openshift-ci openshift-ci bot requested review from agullon and jogeo February 23, 2025 14:39
@ggiguash
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@ggiguash: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-periodic b187970 link true /test e2e-aws-tests-periodic
ci/prow/e2e-aws-tests-bootc-periodic b187970 link true /test e2e-aws-tests-bootc-periodic

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@dhensel-rh dhensel-rh Awaiting requested review from dhensel-rh

@eslutsky eslutsky Awaiting requested review from eslutsky

@agullon agullon Awaiting requested review from agullon

@jogeo jogeo Awaiting requested review from jogeo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pmtk