Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload the OpenShift CAs during Redeem() and ReviewUser() #104

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Reload the OpenShift CAs during Redeem() and ReviewUser() #104

merged 1 commit into from
Mar 1, 2019

Conversation

mrogers950
Copy link

@mrogers950 mrogers950 commented Feb 28, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2019
@mrogers950 mrogers950 requested a review from stlaz February 28, 2019 21:13
@mrogers950
Copy link
Author

/hold
code is wrong

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2019
@mrogers950 mrogers950 force-pushed the reload_ca branch 2 times, most recently from 9a34049 to cd11dda Compare February 28, 2019 22:31
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2019
@mrogers950
Copy link
Author

Changed this to create a new client transport each time instead of mutating the provider transport

enj
enj previously requested changes Feb 28, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2019
@stlaz
Copy link

stlaz commented Mar 1, 2019

/lgtm
It'd be nicer to have the client creation just wrapped up in request(), but this is safer for now.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrogers950, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stlaz
Copy link

stlaz commented Mar 1, 2019

/hold cancel
Code seems fine now

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2019
@stlaz stlaz dismissed enj’s stale review March 1, 2019 07:52

dismissing, was fixed

@openshift-merge-robot openshift-merge-robot merged commit 1a59420 into openshift:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj left review comments

@ericavonb ericavonb Awaiting requested review from ericavonb

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrogers950 @stlaz @openshift-ci-robot @enj @openshift-merge-robot