imagerepos broken for multiple tags w/ same imageid

[bparees]

This commit: 361cdea#diff-5471a801fd55d5af2f431056b6d24254

appears to have made it such that you can't push two different tags for the same image...(ie tag an image as "test" and then later push a prod tag for that same image).

You can see here that my repo does not contain the prod tag, and the json for what is being pushed does contain the prod tag, yet it gets rejected as being identical:
https://gist.github.com/bparees/5235b5bbccad7a78a44d

@smarterclayton @ncdc

[smarterclayton]

We should definitely let you tag it multiple times, just not create it (filter out duplicates). Creating one that already exists and is identical should be "success"

On Feb 25, 2015, at 6:32 PM, Ben Parees [email protected] wrote:

This commit: 361cdea#diff-5471a801fd55d5af2f431056b6d24254

appears to have made it such that you can't push two different tags for the same image...(ie tag an image as "test" and then later push a prod tag for that same image).

You can see here that my repo does not contain the prod tag, and the json for what is being pushed does contain the prod tag, yet it gets rejected as being identical:
https://gist.github.com/bparees/5235b5bbccad7a78a44d

@smarterclayton @ncdc

—
Reply to this email directly or view it on GitHub.

[ncdc]

I have a fix for this

[ncdc]

It's part of a larger refactoring effort, however. I'll try to submit a PR today.

[smarterclayton]

Do we need larger refactors right before beta2? The answer can be yes if the arguments are good enough :)

On Feb 26, 2015, at 5:58 AM, Andy Goldstein [email protected] wrote:

It's part of a larger refactoring effort, however. I'll try to submit a PR today.

—
Reply to this email directly or view it on GitHub.

[ncdc]

It's for https://trello.com/c/ZPKh3cBp/296-3-management-of-historical-image-repository-tags-imageregistry-beta2. Do you want a small PR to fix just this issue?

[ncdc]

I've got a small PR to fix this coming right up in a few minutes :-)