UPSTREAM: 30626: prevent RC hotloop on denied pods #10414
Conversation
|
|
||
| select { | ||
| case err := <-errCh: | ||
| // all errors have been reported before and they're likely to be the same, so we'll only return the first one we hit. |
There was a problem hiding this comment.
This is ok for now but a follow-up issue to actually verify this (or at the very least that we got diff num of errors, meaning all goroutines failed to create) would be nice.
|
Changes LGTM, the RS controller will need the same fix most probably though |
|
[merge] |
My initial check shows that the RS controller has managed to have a different set of bugs. |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7916/) (Image: devenv-rhel7_4831) |
|
Evaluated for origin merge up to b636ccf |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to b636ccf |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7916/) |
Fixes #10407
We'll need to review similar controllers after this one, but this is our biggest risk and I'd like to see the pattern merged before pushing more upstream.
@Kargakis ptal