Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable local storage e2e #22369

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Mar 19, 2019

This depends on openshift/cluster-kube-apiserver-operator#344 and openshift/cluster-kube-controller-manager-operator#195

We are going to re-enable local storage in preparation for 4.1

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2019
@gnufied
Copy link
Member Author

gnufied commented Mar 19, 2019

cc @openshift/sig-storage

@gnufied
Copy link
Member Author

gnufied commented Mar 19, 2019

putting on hold until dependent PRs merge

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@gnufied gnufied force-pushed the enable-local-storage-tests branch from 1fa3dce to f89a891 Compare April 2, 2019 14:42
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@gnufied
Copy link
Member Author

gnufied commented Apr 2, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2019
@jsafrane
Copy link
Contributor

jsafrane commented Apr 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@bertinatto
Copy link
Member

bertinatto commented Apr 4, 2019

/retest

1 similar comment
@jsafrane
Copy link
Contributor

jsafrane commented Apr 5, 2019

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2019
@gnufied gnufied force-pushed the enable-local-storage-tests branch from f89a891 to bb4bce8 Compare April 23, 2019 17:20
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 23, 2019
@gnufied
Copy link
Member Author

gnufied commented Apr 23, 2019

/retest

2 similar comments
@gnufied
Copy link
Member Author

gnufied commented Apr 26, 2019

/retest

@gnufied
Copy link
Member Author

gnufied commented Apr 26, 2019

/retest

@smarterclayton
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@childsb
Copy link
Contributor

childsb commented Apr 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, gnufied, jsafrane, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied
Copy link
Member Author

gnufied commented Apr 27, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0d827d3 into openshift:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/storage size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants