Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAPE-91: Add E2E tests for Route ExternalCertificate feature #29499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OAPE-91: Add E2E tests for Route ExternalCertificate feature #29499

wants to merge 1 commit into from
+780 −0

Conversation

chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Jan 29, 2025 •
edited
Loading

Implements end-to-end tests for routes configured with ExternalCertificate feature. These tests cover the following scenarios:

  • Validation and pre-requisite of the feature

    • Router serviceaccount should have permission to read the secret.
    • The route and the referenced secret must exist in the same namespace.
    • The secret should be of type kubernetes.io/tls.
    • Route with Passthrough termination is not supported.
    • Both external certificates and inline certificates are not allowed.

  • With a valid setup the router should support external certificate.

  • Multiple routes can refer a common secret.

  • Secret delete, re-create and update scenarios.

    • With RBAC permissions validation.

  • Route update scenarios (with validation checks)

    • To use a new external certificate.
    • To use the same external certificate.
    • To remove and again re-add the same external certificate.

Part of: https://issues.redhat.com//browse/OAPE-91

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2025
@openshift-ci openshift-ci bot requested review from coreydaley and deads2k January 29, 2025 12:34
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiragkyal
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2025
@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Jan 29, 2025

Job Failure Risk Analysis for sha: a8bcd79

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout IncompleteTests
Tests for this run (102) are below the historical average (1821): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 12, 2025

Job Failure Risk Analysis for sha: 8898536

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-operator-lifecycle-manager
This test has passed 98.66% of 149 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

@chiragkyal
Copy link
Member Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

@chiragkyal: The following commands are available to trigger required jobs:

/test e2e-aws-jenkins

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test images

/test lint

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback

/test e2e-agnostic-ovn-cmd

/test e2e-aws

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-ipsec-serial

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-ovn-virt-techpreview

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-csi

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial

/test e2e-hypershift-conformance

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial

/test e2e-metal-ipi-serial-ovn-ipv6

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-vsphere

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-e2e-gcp

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd

pull-ci-openshift-origin-master-e2e-aws-csi

pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2

pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones

pull-ci-openshift-origin-master-e2e-aws-ovn-fips

pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-master-e2e-aws-ovn-microshift

pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial

pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade

pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade

pull-ci-openshift-origin-master-e2e-gcp-csi

pull-ci-openshift-origin-master-e2e-gcp-ovn

pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade

pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-master-e2e-hypershift-conformance

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-master-e2e-openstack-ovn

pull-ci-openshift-origin-master-images

pull-ci-openshift-origin-master-lint

pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-origin-master-unit

pull-ci-openshift-origin-master-verify

pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

2 similar comments
@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 12, 2025

Job Failure Risk Analysis for sha: 211d2c4

Job Name Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn High
[sig-arch] Only known images used by tests
This test has passed 100.00% of 25 runs on jobs [periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn] in the last 14 days.

@chiragkyal chiragkyal changed the title [wip] route externalCertificate e2e [wip] Add E2E tests for Route ExternalCertificate feature Feb 13, 2025
@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 13, 2025

Job Failure Risk Analysis for sha: 3f2c35d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-vsphere-ovn-upi Medium
[sig-sippy] infrastructure should work
This test has passed 84.85% of 33 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:upi Network:ovn NetworkStack:ipv4 Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout Low
[Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io]
This test has passed 57.14% of 7 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.

@chiragkyal chiragkyal force-pushed the e2e-ext-crt branch 2 times, most recently from 796ca4a to 8a214b5 Compare February 13, 2025 19:47
@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 14, 2025

Job Failure Risk Analysis for sha: 8a214b5

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Medium
[sig-cli] oc adm images [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]
This test has passed 96.43% of 28 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-single-node] in the last 14 days.

@chiragkyal chiragkyal changed the title [wip] Add E2E tests for Route ExternalCertificate feature Add E2E tests for Route ExternalCertificate feature Feb 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
@chiragkyal chiragkyal changed the title Add E2E tests for Route ExternalCertificate feature OAPE-91: Add E2E tests for Route ExternalCertificate feature Feb 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2025 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references OAPE-91 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 25, 2025 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references OAPE-91 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Implements end-to-end tests for routes configured with ExternalCertificate feature. These tests cover the following scenarios:

  • Validation and pre-requisite of the feature

  • Router serviceaccount should have permission to read the secret.

  • The route and the referenced secret must exist in the same namespace.

  • The secret should be of type kubernetes.io/tls.

  • Route with Passthrough termination is not supported.

  • Both external certificates and inline certificates are not allowed.

  • With a valid setup the router should support external certificate.

  • Multiple routes can refer a common secret.

  • Secret delete, re-create and update scenarios.

    • With RBAC permissions validation.

  • Route update scenarios (with validation checks)

  • To use a new external certificate.

  • To use the same external certificate.

  • To remove and again re-add the same external certificate.

Part of: https://issues.redhat.com//browse/OAPE-91

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@chiragkyal
Copy link
Member Author

/test e2e-gcp-ovn-techpreview

@chiragkyal
Copy link
Member Author

/cc @swghosh @arkadeepsen
/assign @Miciah @alebedev87

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd e222a6c link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-upgrade e222a6c link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn e222a6c link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 e222a6c link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-serial e222a6c link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-kube-apiserver-rollout e222a6c link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout e222a6c link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node e222a6c link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 25, 2025

Job Failure Risk Analysis for sha: e222a6c

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout Low
[Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io]
This test has passed 57.14% of 7 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@deads2k deads2k Awaiting requested review from deads2k

@arkadeepsen arkadeepsen Awaiting requested review from arkadeepsen

@swghosh swghosh Awaiting requested review from swghosh

Assignees

@Miciah Miciah

@alebedev87 alebedev87

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chiragkyal @openshift-ci-robot @Miciah @alebedev87 @openshift-merge-robot