-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix latest aks version command #61980
base: master
Are you sure you want to change the base?
Fix latest aks version command #61980
Conversation
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@@ -77,7 +77,7 @@ fi | |||
if [[ -n "$AKS_K8S_VERSION" ]]; then | |||
AKS_CREATE_COMMAND+=(--kubernetes-version "$AKS_K8S_VERSION") | |||
elif [[ "$USE_LATEST_K8S_VERSION" == "true" ]]; then | |||
K8S_LATEST_VERSION=$(az aks get-versions --location "${AZURE_LOCATION}" --output json --query 'max(orchestrators[*].orchestratorVersion)') | |||
K8S_LATEST_VERSION=$(az aks get-versions --location eastus2 --output json --query 'values[?isPreview==`null`].version | sort(@) | [-1]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use the AZURE_LOCATION env var?
806b1f2
to
2703c96
Compare
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
@@ -77,7 +77,7 @@ fi | |||
if [[ -n "$AKS_K8S_VERSION" ]]; then | |||
AKS_CREATE_COMMAND+=(--kubernetes-version "$AKS_K8S_VERSION") | |||
elif [[ "$USE_LATEST_K8S_VERSION" == "true" ]]; then | |||
K8S_LATEST_VERSION=$(az aks get-versions --location "${AZURE_LOCATION}" --output json --query 'max(orchestrators[*].orchestratorVersion)') | |||
K8S_LATEST_VERSION=$(az aks get-versions --location "${AZURE_LOCATION}" --output json --query 'values[?isPreview==`null`].version | sort(@) | [-1]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the value of K8S_LATEST_VERSION is "1.31" instead of 1.31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ az aks get-versions --location "${AZURE_LOCATION}" --query 'values[?isPreview==null].version | sort(@) | [-1]' -o tsv
1.31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldnt be an issue, but it the query doesnt seem to be working
az aks get-versions --location eastus2 --output json --query 'values[?isPreview==`null`].version | sort(@) | [-1]'
ERROR: Invalid jmespath query supplied for `--query`: In function sort(), invalid type for value: None, expected one of: ['array-string', 'array-number'], received: "null"
2703c96
to
9dcb5bb
Compare
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
9dcb5bb
to
70d29c8
Compare
…ovision-command.sh
70d29c8
to
5b0f3f0
Compare
/lgtm |
[REHEARSALNOTIFIER]
A total of 91 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, heliubj18, Patryk-Stefanski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[REHEARSALNOTIFIER]
A total of 91 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
No description provided.