Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest aks version command #61980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Patryk-Stefanski
Copy link
Contributor

No description provided.

@Patryk-Stefanski
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from bryan-cox and csrwng February 24, 2025 20:05
@@ -77,7 +77,7 @@ fi
if [[ -n "$AKS_K8S_VERSION" ]]; then
AKS_CREATE_COMMAND+=(--kubernetes-version "$AKS_K8S_VERSION")
elif [[ "$USE_LATEST_K8S_VERSION" == "true" ]]; then
K8S_LATEST_VERSION=$(az aks get-versions --location "${AZURE_LOCATION}" --output json --query 'max(orchestrators[*].orchestratorVersion)')
K8S_LATEST_VERSION=$(az aks get-versions --location eastus2 --output json --query 'values[?isPreview==`null`].version | sort(@) | [-1]')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use the AZURE_LOCATION env var?

@Patryk-Stefanski Patryk-Stefanski force-pushed the fix-latest-aks-version-command branch 2 times, most recently from 806b1f2 to 2703c96 Compare February 24, 2025 20:36
@Patryk-Stefanski
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@heliubj18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2025
@@ -77,7 +77,7 @@ fi
if [[ -n "$AKS_K8S_VERSION" ]]; then
AKS_CREATE_COMMAND+=(--kubernetes-version "$AKS_K8S_VERSION")
elif [[ "$USE_LATEST_K8S_VERSION" == "true" ]]; then
K8S_LATEST_VERSION=$(az aks get-versions --location "${AZURE_LOCATION}" --output json --query 'max(orchestrators[*].orchestratorVersion)')
K8S_LATEST_VERSION=$(az aks get-versions --location "${AZURE_LOCATION}" --output json --query 'values[?isPreview==`null`].version | sort(@) | [-1]')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value of K8S_LATEST_VERSION is "1.31" instead of 1.31

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ az aks get-versions --location "${AZURE_LOCATION}" --query 'values[?isPreview==null].version | sort(@) | [-1]' -o tsv
1.31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldnt be an issue, but it the query doesnt seem to be working

az aks get-versions --location eastus2 --output json --query 'values[?isPreview==`null`].version | sort(@) | [-1]'
ERROR: Invalid jmespath query supplied for `--query`: In function sort(), invalid type for value: None, expected one of: ['array-string', 'array-number'], received: "null"

@Patryk-Stefanski Patryk-Stefanski force-pushed the fix-latest-aks-version-command branch from 2703c96 to 9dcb5bb Compare February 25, 2025 11:50
@Patryk-Stefanski
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Patryk-Stefanski Patryk-Stefanski force-pushed the fix-latest-aks-version-command branch from 9dcb5bb to 70d29c8 Compare February 25, 2025 14:26
@Patryk-Stefanski Patryk-Stefanski force-pushed the fix-latest-aks-version-command branch from 70d29c8 to 5b0f3f0 Compare February 25, 2025 14:27
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Patryk-Stefanski: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aks-4-18 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-aks-4-18 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-aks-4-18 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-csi-operator-main-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.20-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.19-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.18-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-main-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.20-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.19-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.18-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-main-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.20-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.19-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.18-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-master-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed

A total of 91 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Patryk-Stefanski
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@Patryk-Stefanski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, heliubj18, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Patryk-Stefanski: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.19-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.18-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aks-4-18 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-aks-4-18 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-aks-4-18 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-master-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-release-4.20-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-release-4.19-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-release-4.18-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-main-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.20-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.19-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.18-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-main-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.20-hypershift-e2e-aks openshift/cluster-image-registry-operator presubmit Registry content changed

A total of 91 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants