Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CNV conformance and informing jobs to the naming conventions #62005

Merged

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Feb 25, 2025

According to the CI jobs naming conventions: https://docs.ci.openshift.org/docs/how-tos/naming-your-ci-jobs/, rename the following jobs:

  • e2e-azure-deploy-cnv --> deploy-azure-kubevirt-ovn
  • e2e-kubevirt-azure-ovn-conformance --> e2e-azure-kubevirt-ovn
  • e2e-aws-ovn-virt-techpreview-periodic --> e2e-aws-kubevirt-ovn-techpreview

With this naming, it is clear whether the job is running conformance suite (e2e prefix), and that are all related to the kubevirt project.

According to the CI jobs naming conventions: https://docs.ci.openshift.org/docs/how-tos/naming-your-ci-jobs/, rename the following jobs:
e2e-azure-deploy-cnv --> deploy-azure-kubevirt-ovn
e2e-kubevirt-azure-ovn-conformance --> e2e-azure-kubevirt-ovn
e2e-aws-ovn-virt-techpreview-periodic --> e2e-aws-kubevirt-ovn-techpreview

With this naming, it is clear whether the job is running conformance suite (e2e prefix), and that are all related to the kubevirt project.

Signed-off-by: Oren Cohen <[email protected]>
@openshift-ci openshift-ci bot requested review from abhat and csrwng February 25, 2025 08:55
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@orenc1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-ovn-kubernetes-release-4.19-periodics-e2e-aws-kubevirt-ovn-techpreview N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.18-deploy-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.16-upgrade-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.19-upgrade-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.17-upgrade-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.18-upgrade-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.16-deploy-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.19-deploy-azure-kubevirt-ovn N/A periodic Periodic changed
periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-aws-kubevirt-ovn-techpreview N/A periodic Periodic changed
periodic-ci-openshift-release-master-cnv-nightly-4.17-deploy-azure-kubevirt-ovn N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@orenc1
Copy link
Contributor Author

orenc1 commented Feb 25, 2025

/pj-rehearse periodic-ci-openshift-ovn-kubernetes-release-4.19-periodics-e2e-aws-kubevirt-ovn-techpreview periodic-ci-openshift-release-master-cnv-nightly-4.19-deploy-azure-kubevirt-ovn periodic-ci-openshift-release-master-cnv-nightly-4.18-deploy-azure-kubevirt-ovn periodic-ci-openshift-release-master-cnv-nightly-4.17-deploy-azure-kubevirt-ovn periodic-ci-openshift-release-master-cnv-nightly-4.16-deploy-azure-kubevirt-ovn periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-azure-kubevirt-ovn

@openshift-ci-robot
Copy link
Contributor

@orenc1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member

Thank you for taking care of this

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@jupierce
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, orenc1, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@orenc1
Copy link
Contributor Author

orenc1 commented Feb 25, 2025

/pj-rehearse ack
@maiqueb , please note the job rename according to the OCP-CI / TRT naming conventions

@openshift-ci-robot
Copy link
Contributor

@orenc1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 25, 2025
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@orenc1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-ovn-kubernetes-release-4.19-periodics-e2e-aws-kubevirt-ovn-techpreview 89b645d link unknown /pj-rehearse periodic-ci-openshift-ovn-kubernetes-release-4.19-periodics-e2e-aws-kubevirt-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 62dd9e2 into openshift:master Feb 25, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants