jsonnet/telemeter/client: move metrics from secret #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the metric match rules for the client out of the secret and directly into the container args. This makes it easier to identify the metrics for anyone inspecting the manifests. This is desirable in order to: 1. increase trust and transparency 2. decrease the chance for mistakes 3. reduce complexity Finally, the metrics are not sensitive and did not need to be in the secret.
openshift-ci-robot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in openshift/cluster-monitoring-operator#290 (comment) and elsewhere, reading
the metrics in secret form is difficult and unnecessary.
This commit moves the metric match rules for the client out of the
secret and directly into the container args. This makes it easier to
identify the metrics for anyone inspecting the manifests. This is
desirable in order to:
Finally, the metrics are not sensitive and did not need to be in the
secret.
Now, the configuration for the client more close matches the server.
cc @s-urbaniak