Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.18.0 #521

Merged
merged 20 commits into from
Jun 25, 2021
Merged

0.18.0 #521

merged 20 commits into from
Jun 25, 2021

Conversation

enricop89
Copy link
Contributor

[Update]: update SDKs iOS to 2.20.0 and Android to 2.20.1
[Fix]: fix crash in OTPublisherLayout when sessionId is null
[Fix]: Update uuidv4 module
[Fix]: OTCustomAudioDrive added file in project.pbxproj

mingtsay and others added 13 commits June 17, 2021 15:56
@enricop89 enricop89 requested review from abdulajet and ggoldens June 24, 2021 08:06
@enricop89
Copy link
Contributor Author

Holding because uuid v8 is broken on React Native: uuidjs/uuid#375

abdulajet
abdulajet approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@abdulajet abdulajet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ggoldens
ggoldens approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ggoldens ggoldens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enricop89 enricop89 merged commit f943e1c into main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggoldens ggoldens ggoldens approved these changes

@abdulajet abdulajet abdulajet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enricop89 @ggoldens @abdulajet @mingtsay