implement sigv4 signing for s3 downloads #21956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-smith-zocdoc
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
tdyas
reviewed
Feb 16, 2025
This comment was marked as resolved.
This comment was marked as resolved.
chris-smith-zocdoc
changed the title
chris-smith-zocdoc
force-pushed
the
cs_fix_aws_sigv4
branch
from
f75e8eb to
6e5b53c
Compare
| # and fallback to us-east-1 | ||
| signing_region = request.region or aws_credentials.default_region or "us-east-1" | ||
|
|
||
| signer = auth.SigV4Auth(aws_credentials.creds, "s3", signing_region) |
There was a problem hiding this comment.
Is it worth supporting the old codepath under a flag (HmacV1Auth)? Not sure risky you view this change as
chris-smith-zocdoc
force-pushed
the
cs_fix_aws_sigv4
branch
from
6e5b53c to
0beaff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21955