Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Replace embedded-elasticsearch with testcontainers-elasticsearch #8943

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 20, 2022

No description provided.

@emeroad emeroad added this to the 2.5.0 milestone Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #8943 (f433789) into master (6208c7c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8943      +/-   ##
============================================
- Coverage     39.92%   39.91%   -0.02%     
+ Complexity    11649    11646       -3     
============================================
  Files          3269     3269              
  Lines         89693    89693              
  Branches       9977     9977              
============================================
- Hits          35810    35799      -11     
- Misses        50823    50828       +5     
- Partials       3060     3066       +6     
Impacted Files Coverage Δ
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...pinpoint/profiler/instrument/AccessorAnalyzer.java 51.61% <0.00%> (-9.68%) ⬇️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+3.70%) ⬆️
...orp/pinpoint/profiler/sender/NioUDPDataSender.java 67.94% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6208c7c...f433789. Read the comment docs.

@emeroad emeroad merged commit 0304cc8 into pinpoint-apm:master Jun 20, 2022
@emeroad emeroad deleted the #noissue_es_testcontainers branch June 21, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant