Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated location.mdx regarding atomWithLocation instances #2805

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

yairEO
Copy link
Contributor

@yairEO yairEO commented Nov 10, 2024

Added an important warning note against instantiating atomWithLocation more than once in an app

Related Bug Reports or Discussions

jotaijs/jotai-location#38

Check List

  • pnpm run prettier for formatting code and docs

Added an important warning note against instantiating `atomWithLocation` more than once in an app
Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 10:11am

Copy link

codesandbox-ci bot commented Nov 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@yairEO yairEO changed the title Update location.mdx Updated location.mdx regarding atomWithLocation instances Nov 10, 2024
Copy link

github-actions bot commented Nov 10, 2024

LiveCodes Preview in LiveCodes

Latest commit: fa99a98
Last updated: Nov 10, 2024 10:10am (UTC)

Playground Link
React demo https://livecodes.io?x=id/HZQCNM2MA

See documentations for usage instructions.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Check CI errors.

@dai-shi dai-shi merged commit cce115f into pmndrs:main Nov 10, 2024
40 checks passed
dmaskasky pushed a commit to dmaskasky/jotai that referenced this pull request Nov 14, 2024
…#2805)

* Update location.mdx

Added an important warning note against instantiating `atomWithLocation` more than once in an app

* ran `prettier` npm script and added 2 `code` annotations for the new paragraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants