Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): improve useAtomCallback performance #644

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 7, 2021

close #641

@vercel
Copy link

vercel bot commented Aug 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/Gu5NvMiSf2tvnn47etLwVUbH2ayA
✅ Preview: https://jotai-git-fix-issue-641-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c02cf0d:

Sandbox Source
React Configuration
React Typescript Configuration
Demonstration of useAtomCallback performance issues Issue #641

@dai-shi dai-shi marked this pull request as ready for review August 9, 2021 22:42
@dai-shi dai-shi requested a review from Thisen August 9, 2021 22:45
Copy link
Collaborator

@Thisen Thisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dai-shi dai-shi merged commit 770dcee into master Aug 10, 2021
@dai-shi dai-shi deleted the fix/issue-641 branch August 10, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useAtomCallback creates a lot of atoms, resulting in performance issues
2 participants