Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table of contents updates #166

Merged
merged 7 commits into from
Aug 26, 2020
Merged

Table of contents updates #166

merged 7 commits into from
Aug 26, 2020

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Aug 25, 2020 •
edited
Loading

This PR addresses the table of contents feedback in #137. Here's what changed:

👉 Preview

  • Reduced the font size of the table of contents items from 16px to 14px
Before After
  • Increased the max width of main content area to 960px
Before After
  • Limited the depth of the table of contents to h3
Before After
  • Collapsed empty table of contents items
Before After
  • Updated mobile table of contents based on @ashygee's designs (I kept the font size at 16px on mobile because 14px seemed too small and hard to tap on mobile screens)
Before After
image image image image

Closes #137

@colebemis colebemis requested review from emplums and ashygee August 25, 2020 19:31
@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

doctocat – ./

🔍 Inspect: https://vercel.com/primer/doctocat/1sue449vf
✅ Preview: https://doctocat-git-toc-updates.primer.vercel.app

gatsby-theme-primer-example – ./

🔍 Inspect: https://vercel.com/primer/gatsby-theme-primer-example/fej3b9evm
✅ Preview: https://gatsby-theme-primer-example-git-toc-updates.primer.vercel.app

ashygee
ashygee approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually this looks much better! Approved!

emplums
emplums approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! want to go ahead and ship a release from this PR as well?

@colebemis colebemis changed the base branch from master to release-0.24.0 August 26, 2020 19:54
@colebemis colebemis merged commit 8ac447d into release-0.24.0 Aug 26, 2020
This was referenced Aug 26, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

@ashygee ashygee ashygee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table of Contents Feedback
3 participants
@colebemis @emplums @ashygee