Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): update gatsby to v3 #479

Merged
merged 22 commits into from
Aug 28, 2023
Merged

feat(theme): update gatsby to v3 #479

merged 22 commits into from
Aug 28, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 15, 2022

Migration guide

Checklist

  • @primer/gatsby-theme-doctocat
  • docs
    • Update Gatsby to 3.x
    • Change __experimentalThemes to plugins in docs (Reference)

Sites

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

🦋 Changeset detected

Latest commit: 770acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/gatsby-theme-doctocat Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack temporarily deployed to github-pages September 15, 2022 20:51 Inactive
@joshblack joshblack temporarily deployed to github-pages September 15, 2022 21:24 Inactive
@joshblack joshblack temporarily deployed to github-pages September 15, 2022 21:27 Inactive
@joshblack joshblack temporarily deployed to github-pages September 15, 2022 21:32 Inactive
@joshblack
Copy link
Member Author

@colebemis ended up moving #466 over into this PR and linked some of the sites that I've done PRs for with the prerelease package.

Would you recommend other sites that use the gatsby theme that I should include? 👀

@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 29, 2022
@github-actions github-actions bot closed this Dec 6, 2022
@github-actions github-actions bot deleted the feat/update-gatsby-v3 branch December 6, 2022 22:02
@mperrotti mperrotti restored the feat/update-gatsby-v3 branch July 19, 2023 17:08
@mperrotti mperrotti reopened this Jul 19, 2023
@mperrotti mperrotti temporarily deployed to github-pages July 19, 2023 17:11 — with GitHub Actions Inactive
@josepmartins josepmartins temporarily deployed to github-pages July 20, 2023 07:48 — with GitHub Actions Inactive
@mperrotti
Copy link
Contributor

mperrotti commented Jul 20, 2023

@josepmartins and I branched off of this and tried (and failed) to upgrade React and PRC.

We're running into this issue: gatsbyjs/gatsby#26785

Here's how we tried to get around it:

  • The webpack build hack in this comment
  • Using npm instead of yarn
  • Skipping v3 and going straight to v4

@github-actions github-actions bot removed the Stale label Jul 20, 2023
@radglob radglob temporarily deployed to github-pages August 21, 2023 14:44 — with GitHub Actions Inactive
@radglob radglob temporarily deployed to github-pages August 23, 2023 15:44 — with GitHub Actions Inactive
@radglob
Copy link
Contributor

radglob commented Aug 23, 2023

Adding yarn resolutions for graphql and graphql-compose seems to make this work.

After adding that and linking a local copy of the repo to docs/package.json in my local copy of @primer/react

{
  "dependencies": {
    "@primer/gatsby-theme-doctocat": "../../doctocat/theme",
    ...
  }
  ...
}

Everything builds fine. No graphql issues, whole thing renders correctly.

The migration docs mention it here.

@radglob radglob temporarily deployed to github-pages August 24, 2023 18:28 — with GitHub Actions Inactive
@radglob radglob requested review from a team and langermank August 25, 2023 15:06
@radglob radglob temporarily deployed to github-pages August 25, 2023 15:10 — with GitHub Actions Inactive
@lesliecdubs
Copy link
Member

Bumping for review. @langermank it looks like you were auto-assigned a while back, do you have bandwidth to take a look?

@radglob radglob temporarily deployed to github-pages August 25, 2023 16:35 — with GitHub Actions Inactive
Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for finally getting this working @radglob !

@radglob radglob merged commit 7b07123 into main Aug 28, 2023
@radglob radglob deleted the feat/update-gatsby-v3 branch August 28, 2023 17:28
@primer-css primer-css mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants