-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): update gatsby to v3 #479
Conversation
🦋 Changeset detectedLatest commit: 770acce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@colebemis ended up moving #466 over into this PR and linked some of the sites that I've done PRs for with the prerelease package. Would you recommend other sites that use the gatsby theme that I should include? 👀 |
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
@josepmartins and I branched off of this and tried (and failed) to upgrade React and PRC. We're running into this issue: gatsbyjs/gatsby#26785 Here's how we tried to get around it:
|
Adding yarn After adding that and linking a local copy of the repo to
Everything builds fine. No graphql issues, whole thing renders correctly. The migration docs mention it here. |
Bumping for review. @langermank it looks like you were auto-assigned a while back, do you have bandwidth to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for finally getting this working @radglob !
Migration guide
Checklist
@primer/gatsby-theme-doctocat
gatsby-plugin-styled-components
(babel-plugin-styled-components
andstyled-components
)docs
__experimentalThemes
toplugins
indocs
(Reference)Sites