Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About us link and style fixes #613

Merged
merged 6 commits into from
Jul 26, 2023
Merged

About us link and style fixes #613

merged 6 commits into from
Jul 26, 2023

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented Jul 24, 2023 •
edited
Loading

  • Fixes the about link in primer nav
  • Removes mono space font in the nav drawer + fontweight bold to match top left navigation
  • Uses 16px in the top navigation
Before After
Screenshot 2023-07-24 at 08 49 34 Screenshot 2023-07-24 at 08 49 18

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: fadfa3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/gatsby-theme-doctocat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@josepmartins josepmartins self-assigned this Jul 24, 2023
@josepmartins josepmartins temporarily deployed to github-pages July 24, 2023 06:49 — with GitHub Actions Inactive
@josepmartins josepmartins changed the title Fix about us link About us link and style fixes Jul 24, 2023
@josepmartins josepmartins temporarily deployed to github-pages July 24, 2023 06:55 — with GitHub Actions Inactive
@josepmartins josepmartins temporarily deployed to github-pages July 24, 2023 07:18 — with GitHub Actions Inactive
emilybrick
emilybrick approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🚀 Thank you!

@josepmartins josepmartins merged commit e2cd01a into main Jul 26, 2023
@josepmartins josepmartins deleted the josepmartins/fixes branch July 26, 2023 06:06
@primer-css primer-css mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilybrick emilybrick emilybrick approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees

@josepmartins josepmartins

Labels
status: wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josepmartins @emilybrick