Skip to content

Commit

Permalink
Merge branch 'main' into use-command-commandfor-over-custom-data-show…
Browse files Browse the repository at this point in the history
…-close-submit-dialog-id
  • Loading branch information
keithamus authored Feb 17, 2025
2 parents 53270ba + a2442cc commit d2df131
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions app/components/primer/beta/markdown.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
module Primer
module Beta
# Use `Markdown` to wrap markdown content.
# @accessibility This component is purely presentational. Consumers should handle accessibility expectations, such as ensuring that an overflowing, scrollable code block or table is keyboard accessible.
class Markdown < Primer::Component
status :beta

Expand Down
8 changes: 4 additions & 4 deletions previews/primer/beta/markdown_preview.rb
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class MarkdownPreview < ViewComponent::Preview
<p>If a table is too wide, it should condense down and/or scroll horizontally.</p>
<table>
<table tabindex="0">
<thead>
<tr>
<th>Artist</th>
Expand Down Expand Up @@ -237,13 +237,13 @@ class MarkdownPreview < ViewComponent::Preview
<pre><code>var foo = \"bar\";</code></pre>
<pre><code>Long, single-line code blocks should not wrap. They should horizontally scroll if they are too long. This line should be long enough to demonstrate this.</code></pre>
<pre tabindex="0"><code>Long, single-line code blocks should not wrap. They should horizontally scroll if they are too long. They should also have a tabindex=0 to ensure keyboard accessibility. This line should be long enough to demonstrate this.</code></pre>
<pre><code>var foo = \"The same thing is true for code with syntax highlighting. A single line of code should horizontally scroll if it is really long.\";</code></pre>
<pre tabindex="0"><code>var foo = \"The same thing is true for code with syntax highlighting. A single line of code should horizontally scroll if it is really long.\";</code></pre>
<p>Inline code inside table cells should still be distinguishable.</p>
<table>
<table tabindex="0">
<thead>
<tr>
<th>Language</th>
Expand Down
2 changes: 1 addition & 1 deletion static/info_arch.json
Original file line number Diff line number Diff line change
Expand Up @@ -14520,7 +14520,7 @@
{
"fully_qualified_name": "Primer::Beta::Markdown",
"description": "Use `Markdown` to wrap markdown content.",
"accessibility_docs": null,
"accessibility_docs": "This component is purely presentational. Consumers should handle accessibility expectations, such as ensuring that an overflowing, scrollable code block or table is keyboard accessible.",
"is_form_component": false,
"is_published": true,
"requires_js": false,
Expand Down

0 comments on commit d2df131

Please sign in to comment.