Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limiting max trace #740

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Limiting max trace #740

merged 2 commits into from
Sep 9, 2024

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Sep 2, 2024 •
edited
Loading

Description

This PR limits max recursion to 255 + fix cname following with projectdiscovery/retryabledns#225

# time echo lb.devicemanager.central.arubanetworks.com|go run . -rc servfail -r 1.1.1.1 -trace

      _             __  __
   __| | _ __   ___ \ \/ /
  / _' || '_ \ / __| \  /
 | (_| || | | |\__ \ /  \
  \__,_||_| |_||___//_/\_\

                projectdiscovery.io

[INF] Current dnsx version 1.2.1 (latest)
lb.devicemanager.central.arubanetworks.com [SERVFAIL]

real    0m5.197s
user    0m2.745s
sys     0m0.816s

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 2, 2024
@Mzack9999 Mzack9999 self-assigned this Sep 2, 2024
@Mzack9999 Mzack9999 linked an issue Sep 2, 2024 that may be closed by this pull request
Default -trace-max-recursion causes a server crash #707
Closed
@Mzack9999 Mzack9999 mentioned this pull request Sep 2, 2024
Closed
@Mzack9999 Mzack9999 merged commit 60c06f2 into dev Sep 9, 2024
11 checks passed
@Mzack9999 Mzack9999 deleted the bugfix-707-trace-cname branch September 9, 2024 21:46
@BrewTestBot BrewTestBot mentioned this pull request Feb 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default -trace-max-recursion causes a server crash
1 participant
@Mzack9999