bugfix in prepareQuery for pouchdb #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubkey
added a commit
that referenced
this pull request
May 24, 2020
|
@kunal15595 wow, great work. I moved the test and added the bugfix to the changelog. merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
In
rx-storage-pouchdb.prepareQuery, agtoperator in selector is added if not already present.This creates a problem if the selector originally has
gteoperator aspouch-findinternally merges startKey for both these operators, mostly overriding gte with gt.This PR checks for any comparison operators in selector for that key, and adds that hack only if required, and thereby avoiding reproduced issue.
Todos