Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugReport] DexieStorage and array of string #3778

Closed
wants to merge 10 commits into from

Conversation

mmouterde
Copy link
Contributor

This PR contains:

  • A BUGFIX

Describe the problem you have without this PR

With Dexie storage, I push documents like
{ stringArray: [ 'bob','paul'] }
and get
{ stringArray: [ {0:'b', 1:'o', 2:'b'},{0:'p',1:'a',2:'ul'}] }

After investigations, I did not find the root cause.

Todos

  • Fix the bug

 Could be set to `false` to avoid  initialReplication on replicateRxCollection().

default to true to avoid breaking change.
In this case, the first run() starts the polling loop.
It was always false positive as changing liveInterval to >0 had no effect, and that is the purpose of the tests.

Now, we insert document, that triggers a push and we get a proof properly.
mmouterde added a commit to mmouterde/rxdb that referenced this pull request Apr 28, 2022
@mmouterde mmouterde mentioned this pull request Apr 28, 2022
@pubkey pubkey closed this in #3779 Apr 28, 2022
pubkey added a commit that referenced this pull request Apr 28, 2022
mmouterde added a commit to mmouterde/rxdb that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant