-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(console.commands.command.Command): restore the set_poetry instance method (removed in Poetry v2) #9981
fix(console.commands.command.Command): restore the set_poetry instance method (removed in Poetry v2) #9981
Conversation
Reviewer's Guide by SourceryThis pull request restores the Class diagram showing Command class with restored set_poetry methodclassDiagram
class Command {
-_poetry: Poetry
+poetry(): Poetry
+set_poetry(poetry: Poetry): void
+get_application(): Application
}
note for Command "Restored set_poetry method"
class Poetry {
}
class Application {
}
Command --> Poetry: has
Command --> Application: returns
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DavidVujic - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add tests for the restored set_poetry method to prevent future regressions
- Documentation should be updated to explain why this previously removed method is being restored
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d01015f
to
91666b2
Compare
…e method, removed in Poetry v2
91666b2
to
0758b22
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #9980
Summary by Sourcery
Bug Fixes:
set_poetry
instance method, addressing compatibility issues with Poetry v2.