Update CadenceMemoryPlanning to support per-memory alignment constraint #8689
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8689
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5086067 with merge base f9dc6ef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69881079 |
|
@pytorchbot label "topic: not user facing" |
dulinriley
approved these changes
Feb 25, 2025
zonglinpeng
approved these changes
Feb 25, 2025
sabarishsnk
added a commit
to sabarishsnk/executorch
that referenced
this pull request
Feb 25, 2025
…nt (pytorch#8689) Summary: Currently `CadenceMemoryPlanning` only supports a single `mem_alignment` parameter that it applies to all memories in the hierarchy. This diff moves the alignment constraint to the `MemoryConfig` definition and makes it per-memory. Reviewed By: dulinriley, zonglinpeng Differential Revision: D69881079
sabarishsnk
force-pushed
the
export-D69881079
branch
from
ce51fe5 to
ad81cba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69881079 |
…nt (pytorch#8689) Summary: Currently `CadenceMemoryPlanning` only supports a single `mem_alignment` parameter that it applies to all memories in the hierarchy. This diff moves the alignment constraint to the `MemoryConfig` definition and makes it per-memory. Reviewed By: dulinriley, zonglinpeng Differential Revision: D69881079
sabarishsnk
force-pushed
the
export-D69881079
branch
from
ad81cba to
5086067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently
CadenceMemoryPlanningonly supports a singlemem_alignmentparameter that it applies to all memories in the hierarchy. This diff moves the alignment constraint to theMemoryConfigdefinition and makes it per-memory.Reviewed By: dulinriley
Differential Revision: D69881079