Fix #10629 - Duplicating Surveys

[SinergiaCRM]

Closes #8947

As the Issue mentions, there is a problem when duplicating Surveys. Basically, what goes wrong when duplicating:

• If the base survey has questions and no answers, the duplicated survey will take all the questions, leaving the base survey without questions
• If the base survey has questions and answers, the duplicated survey won't take/keep the questions, neither the answers. Although the Editview that appears after duplicating will contain the questions and won't allow it to modify them:
  

Closes #10629

Having a WorkFlow and duplicating a survey or create also duplicated the questions, as the code was executed without any workflow verification. This was because:

• When duplicating survey X to Y or creating survey X, having WorkFlow active, the code saved the questions normally.
• But because there was no control over the workflow, when the workflow was executed:
  • The code re-executed the foreach loop that saves the questions.
  • As a result, the questions were saved twice: once during the normal save and once during the workflow execution.

Description

This PR fixes the Duplicate functionality for the Surveys module, as we understand it should work:

• If the base survey has questions and no answers, the duplicated survey will keep the questions, duplicating them.
• If the base survey has questions and answers, the duplicated survey won't will take/keep/duplicate the questions or but not the answers. And other new Questions can be added during the first edition after duplication.
• Fixed the workflow problem by adding a control variable already_saved which is used to verify that the method is not re-executed. If already_saved is set, it means that the method has already been executed and reprocessing of the questions is avoided.

Motivation and Context

With this change, duplicating Surveys will be consistent.

How To Test This

1- Create a Survey
2- Add questions
3- Duplicate it.
4- Repeat adding answers to the survey.

• Workflow Issue:

1. WorkFlow Module: Surveys
2. Run: Only On Save
3. Run On: New Records
4. Action:
   4.1. Modify the survey itself, for example, change from draft to published status.
   4.2. Calculate fields, for example, calculate the name.
5. Duplicate the survey from step 1, checking the number of questions it has.
6. Check that the survey has been duplicated without duplicating the questions and that it has the same questions as the survey from step 1.
7. Create a survey with several questions and check that the surveys are not duplicated.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[jack7anderson7]

Hi @SinergiaCRM,

The fix looks good, there's just one change that would be ideal. When duplicating surveys it is preferred if the questions are always carried across even when they have answers, just the answers wouldn't.

Thanks,
Jack

[SinergiaCRM]

Hi @SinergiaCRM,

The fix looks good, there's just one change that would be ideal. When duplicating surveys it is preferred if the questions are always carried across even when they have answers, just the answers wouldn't.

Thanks, Jack

Hi @jack7anderson7,

Yes, this was actually what we wanted to implement. Updated the main PR message and the code. 👍

[SinergiaCRM]

Updated the code, there was a syntax error

[phil8900]

Fix is working and should be merged I think. @jack7anderson7 could you take a look at this? :)

[serhiisamko091184]

Hello @SinergiaCRM ,
thanks a lot for your contribution,

would you be so kind to combine commits into one?

Thank you in advance!

Regards,
Serhii

[SinergiaCRM]

Hello @SinergiaCRM , thanks a lot for your contribution,

would you be so kind to combine commits into one?

Thank you in advance!

Regards, Serhii

Hi @serhiisamko091184

Done!

[serhiisamko091184]

Hello @SinergiaCRM,

great, many thanks!

Please update your branch later on:

Regards,
Serhii

[SuiteBot]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ SinergiaCRM
❌ AlbertoSTIC
_{You have signed the CLA already but the status is still pending? Let us recheck it.}