Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codebase to Java 17+: Switch to records, use ZonedDateTime, Nullable annotations #188

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

sdstoehr
Copy link
Owner

Upgrade codebase to Java 17+

  • Use records
  • Use ZonedDateTime rather than Date
  • Annotate fields with @Nullable/@Nonnull

Important

These changes imply several breaking changes, please test your code base thoroughly.

  • Getters are now named .property() rather than .getProperty()
  • We are now using ZonedDateTime (which supports higher precision) rather than outdated Date class
  • The enums HttpStatus and HttpMethod are now only used optionally. int status() is now returning the status code as it was in the har file (previously it returned 0 for unknown status codes). String method() is now also returning the http method as it was in the har file. The enums are now available as .httpStatus() and .httpMethod()

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (fcdb942) to head (cd39e90).
Report is 3 commits behind head on release/3.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/3.0     #188       +/-   ##
==================================================
+ Coverage          79.47%   98.14%   +18.67%     
+ Complexity           401      141      -260     
==================================================
  Files                 27       27               
  Lines                726      324      -402     
  Branches             131       48       -83     
==================================================
- Hits                 577      318      -259     
+ Misses               149        6      -143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdstoehr sdstoehr merged commit 70a38b1 into release/3.0 Dec 21, 2024
2 checks passed
@sdstoehr sdstoehr deleted the java17 branch December 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant