Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat task 1602 new detector interface #1025

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

serengil
Copy link
Owner

Tickets

#1021

What has been done

With this PR,

  • Detector interface is changed. Now, all detectors are returning facial area coordinates, eye coordinates and confidence score. They are not responsible for extracting face, alignment or expanding facial area.
  • Extracting face, alignment and expanding facial area are now done in DetectorWrapper which is the parent object of those detectors.
  • Besides, we are now align first and extract facial area second not to have many black pixels.

How to test

make lint && make test

@serengil serengil merged commit ee4ad41 into master Feb 16, 2024
4 checks passed
@serengil serengil deleted the feat-task-1602-new-detector-interface branch February 16, 2024 17:51
@serengil
Copy link
Owner Author

Comparative results are shown in the following illustration

align-first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant