Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flutter 3.24 and later. Support textScaler in favor of the deprecated textScaleFactor. Upgrade the demo project and dependencies #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mlb5000
Copy link

@mlb5000 mlb5000 commented Sep 17, 2024

This is primarily to fix the issue described here, which can cause crashes and failed rendering on Flutter 3.24.0 and later. I have tested this against Flutter 3.24.3 and went through each example on the Demo app, which appeared to function exactly as we would want.

* Remove use of deprecated `textScaleFactor` in place of the preferred `TextScaler` (https://docs.flutter.dev/release/breaking-changes/deprecate-textscalefactor)
* Upgrade required Dart SDK versions, make necessary project updates on Android demo app
@mlb5000 mlb5000 changed the title Support textScaler in favor of the deprecated textScaleFactor. Upgrade the demo project and dependencies Fix Flutter 3.24 and later. Support textScaler in favor of the deprecated textScaleFactor. Upgrade the demo project and dependencies Sep 17, 2024
@vasilich6107
Copy link

this package does not seem to be supported for last 2 years

@plchekspend
Copy link

Any update @simc @pdblasi-google ?

@FaFre
Copy link

FaFre commented Feb 23, 2025

Since this repo has been unmaintained for a couple of years now, I decided to fork it and merge all the outstanding PR's: https://github.com/FaFre/auto_size_text/blob/master/CHANGELOG.md

The package also has been pushed to pub: https://pub.dev/packages/flutter_auto_size_text

@vasilich6107
Copy link

@FaFre the auto sizing of the text is s bit unpredictable and confronts with accessibility so there are some disadvantages of using it

@FaFre
Copy link

FaFre commented Feb 23, 2025

@vasilich6107 is this an ongoing issue on the flutter side? TextScaler is the official replacement of the deprecated textScaleFactor which will be probably removed in one of the upcoming releases. If there are issues with it, we need to report them to the flutter team.

For my part I checked it in the demo app and ran some test in my app (pretty tight use case) and I didn't had any issues with latest flutter release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants