Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(View): extend pai.create to support views #1549

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

scaliseraoul
Copy link
Contributor

@scaliseraoul scaliseraoul commented Jan 27, 2025


Important

Extend create() to support views and replace connector with source, updating path validation and tests.

  • Behavior:
    • Extend create() in __init__.py to support views with source and relations parameters.
    • Replace connector with source in create().
    • Add validation for dataset paths using get_validated_dataset_path().
  • Models:
    • Update SemanticLayerSchema in semantic_layer_schema.py to handle views and relations.
  • Tests:
    • Update tests in test_pandasai_init.py to reflect changes from connector to source.
    • Add tests for creating datasets with views.

This description was created by Ellipsis for a69922b. It will automatically update as commits are pushed.

@scaliseraoul-sinaptik scaliseraoul-sinaptik marked this pull request as ready for review January 27, 2025 17:27
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 27, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a69922b in 1 minute and 44 seconds

More details
  • Looked at 331 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. pandasai/__init__.py:57
  • Draft comment:
    The docstring mentions connector instead of source. Update the docstring to reflect the correct parameter name source.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. pandasai/__init__.py:82
  • Draft comment:
    The error message refers to connector instead of source. Update the error message to reflect the correct parameter name source.
  • Reason this comment was not posted:
    Marked as duplicate.
3. tests/unit_tests/test_pandasai_init.py:797
  • Draft comment:
    The error message refers to connector instead of source. Update the error message to reflect the correct parameter name source.
  • Reason this comment was not posted:
    Marked as duplicate.
4. pandasai/__init__.py:118
  • Draft comment:
        raise InvalidConfigError("Please provide either a DataFrame or a source")
  • Reason this comment was not posted:
    Marked as duplicate.
5. tests/unit_tests/test_pandasai_init.py:797
  • Draft comment:
            InvalidConfigError, match="Please provide either a DataFrame or a source"
  • Reason this comment was not posted:
    Marked as duplicate.
6. tests/unit_tests/test_pandasai_init.py:808
  • Draft comment:
        with pytest.raises(ValueError, match="df must be a PandaAI DataFrame"):
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_MuoK0FzAfDEWQFTB


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@gventuri gventuri merged commit 56bdd8c into sinaptik-ai:release/v3 Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants