We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minTimeout
Hey,
I accidentally noticed that the following code overrides the default minTimeout value (1000) to 0:
1000
0
await pRetry(run, { minTimeout: undefined });
This happens due to the retry logic for resolving options: https://github.com/tim-kos/node-retry/blob/master/lib/retry.js#L17-L26
retry
options
Is this expected behavior?
Decided to report this because it's unusual behavior, and probably not everyone (including me 🙈) would expect it.
The text was updated successfully, but these errors were encountered:
Use default minTimeout when set as undefined
696a857
Fixes sindresorhus#86
Successfully merging a pull request may close this issue.
Hey,
I accidentally noticed that the following code overrides the default
minTimeout
value (1000
) to0
:This happens due to the
retry
logic for resolvingoptions
:https://github.com/tim-kos/node-retry/blob/master/lib/retry.js#L17-L26
Is this expected behavior?
Decided to report this because it's unusual behavior, and probably not everyone (including me 🙈) would expect it.
The text was updated successfully, but these errors were encountered: