Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix outside click closing bug for PortalWithState #189

Merged
merged 1 commit into from
Dec 17, 2017
Merged

fix outside click closing bug for PortalWithState #189

merged 1 commit into from
Dec 17, 2017

Conversation

DevinXian
Copy link
Contributor

When property node was set for <PortalWithState />, click outside the portal will not close properly~ Because the defaultNode does not exist if props.node defined

@tajo
Copy link
Owner

tajo commented Dec 17, 2017

Thanks!

@tajo tajo merged commit 2bc16c7 into tajo:master Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevinXian @tajo