[readme] Update the documention for t.doesNotThrow() #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Your text is correct, but node's docs say that it does check the type - in terms of what kind of error is thrown. Since tape fails the test instead of throwing an error, it kind of seems like we should be failing the test when it doesn't throw the right kind of error, and instead, throwing the error when it throws the wrong kind of error? |
ljharb
force-pushed
the
master
branch
3 times, most recently
from
c16dde3 to
2ad86d4
Compare
|
@m-r-r unfortunately by deleting the fork, this PR is unrecoverable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I updated the documentation for
t.doesNotThrow()to clarify how it works.Fixes #553.