Make logging generic across backends and simplify logging code #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna go ahead and merge given there's been no complaints and it seems to work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we never hooked into GGML's logging backend. #196 requested this, and I figured I'd use this as a chance to clean up this code anyways. All logging code has been moved into
whisper_rs::install_logging_hooks(), and it will log to neither, both, or one oflogortracingdepending on which features are enabled. This is a possible footgun but the breaking changes here should limit its impact to be minimal since people should be reading the docs anyways.