Use $pick() when across(.fns = NULL) is specified
#6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.fns = NULL` will eventually be deprecated in favor of an official way to select columns, but the new way will have the same semantics of preserving list-columns as-is
hadley
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Yeah, this looks a lot cleaner to me.
You might also want to remove the same old test that I did at https://github.com/tidyverse/dplyr/pull/6380/files#diff-45e563b486cc3a0bec1b439f59112c55a9ef8688d3ae465ce8fda8ac2c7c576fL514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6380 (alternative)
Closes #6264
@hadley I think I like this approach more?
current_cols()(which I think shouldn't ever alter the cols if possible)pick()function would do. It would be semantically the same asacross(.fns = NULL), so it is nice to see that we internally use$pick()for theacross(.fns = NULL)code path.I think this further supports the need for
pick(). It would allow us to "purify"across()a bit more with rowwise data frames. Once we deprecate.fns = NULL,across()would always work directly on list column elements VSpick()which would always preserve the full list-column as-is