POC: Position guides have acces to layer data #6343
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6247.
Briefly, it adds the plumbing to let panel data reach the
get_layer_key()
method of position guides.I've put this in as a draft, because I'm not entirely sure that we should take this approach.
It has some overhead because it needs to split up data by panel, making code slower.
We can illustrate with this benchmark:
Created on 2025-02-21 with reprex v2.1.1
The exact same code on the main branch gives this result:
To illustrate that it works, we can assemble a quick-and-dirty guide extension that displays a density line for the data it sees, instead of the actual axis line.
Created on 2025-02-21 with reprex v2.1.1