Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arrow cache only for index scans #7724

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erimatnor
Copy link
Contributor

Since compressed segments are accessed sequentially during sequence/columnar scans, it is not necessary to cache the decompressed arrow arrays.

Instead, use the arrow cache only if an index scan is detected. Also make it possible to manually disable the cache by setting the GUC hypercore_arrow_cache_max_entries to 0.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (59f50f2) to head (c855d77).
Report is 783 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/hypercore/arrow_tts.c 87.50% 0 Missing and 5 partials ⚠️
tsl/src/hypercore/arrow_array.c 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7724      +/-   ##
==========================================
+ Coverage   80.06%   81.95%   +1.88%     
==========================================
  Files         190      247      +57     
  Lines       37181    45460    +8279     
  Branches     9450    11363    +1913     
==========================================
+ Hits        29770    37256    +7486     
- Misses       2997     3730     +733     
- Partials     4414     4474      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since compressed segments are accessed sequentially during
sequence/columnar scans, it is not necessary to cache the
decompressed arrow arrays.

Instead, use the arrow cache only if an index scan is detected. Also
make it possible to manually disable the cache by setting the GUC
hypercore_arrow_cache_max_entries to 0.
@erimatnor erimatnor force-pushed the hypercore-only-use-arrow-cache-for-indexscan branch from f9606d0 to c855d77 Compare February 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant