Add support for Browser SDK #75
Conversation
There was a problem hiding this comment.
Yooo! Thank you so much for taking the time and making a browser sdk example! 😄
I just have a single question / comment, the rest of the comments are just cool things I noticed :)
I'll also reach out to the as-bind user that I know of to take a look at this as well! 😄
| // as is expected by most transform modules. | ||
| define("assemblyscript", assemblyscript); | ||
| // Load our ASBind transform... | ||
| require(["/dist/transform.amd.js"], transform => { |
There was a problem hiding this comment.
Woooaaahhh that's interesting how you load a transform in the browser SDK 😯
|
And I got a little antsy, so I tried it out, and it works! That's so rad 😄 🎉
|
|
Alright, if you are conceptually on-board with this, then I’m happy! I’ll wait to hear from you about said as-bind user. If they are cool, I’ll merge this and make sure to cover this in the README update that’s next :D |
|
What if we'd add a |
|
@dcodeIO yeah something like that would work well for my use-cases with transforms. Even just being allowed to push onto the Maybe @willemneal has thoughts on this, too, as he has spent a lot more time with transforms than I have. |
|
@torch2424 wdyt? Should we move forward with this? |
|
@surma My bad for the late reply! I've been moving work computers, so I was re-getting access to everything on my new machine 🙃
So I did reach out to them, but they didn't get back to me. Though, since @dcodeIO made it really easy to include transforms, I think we could totally move forward with this! 😄 |
|
@surma Let me know when this is good to merge. I know the CI is failing, but that's as expected right? 😄 |
|
Yeah, I need to take a closer look at CI! Let’s merge this and I’ll whip up a new README 🎉 |
This adds an AMD build of the transform and an example show-casing how to use the transform with the Browser SDK.
It’s not clean by any means, but it’s a deeper issue with how the Browser SDK currently handles dynamic requires (as in: it expects them to be synchronously loaded). To work around this requirement, I’m using a
Proxyto shimrequire()to give the transform some special handling. See the example HTML file for details (cc @dcodeIO for visibility and/or ideas).@torch2424 This does work, so that’s pretty cool :D But you said you had a user who relies on the browser SDK. I’d be curious if this is acceptable for them.