Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other AuthTypes in addition to BasicAuth #755

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nakulgan
Copy link

@nakulgan nakulgan commented Feb 6, 2025

Fixes #524

Copy link

cla-bot bot commented Feb 6, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

* **src/index.ts**
  - Add `OAuth2Auth` class implementing the `Auth` interface
  - Update `Client.create` method to handle `OAuth2Auth` authentication type
  - Remove other authentication types except `BasicAuth` and `OAuth2Auth`
* **README.md**
  - Update "Features" section to mention support for Basic and OAuth2 authentication types
  - Add examples for using `OAuth2Auth` in the "Usage" section
* **tests/it/client.spec.ts**
  - Add integration tests for `OAuth2Auth` authentication type
Copy link

cla-bot bot commented Feb 6, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

…ntication

* **OAuth2Auth class**
  - Add new class `OAuth2Auth` implementing the `Auth` interface for OAuth2 authentication
  - Add support for additional properties: `clientId`, `clientSecret`, `refreshToken`, `tokenEndpoint`

* **Client.create method**
  - Update to handle the new `OAuth2Auth` authentication type
  - Remove other authentication types except `BasicAuth` and `OAuth2Auth`

* **README.md**
  - Update example for using the new `OAuth2Auth` authentication type
Copy link

cla-bot bot commented Feb 6, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

* Add `scopes`, `tokenType`, `expiresIn`, `redirectUri`, and `grantType` properties to `OAuth2Auth` class
* Update `Client.create` method to handle new properties in `OAuth2Auth` authentication type
Copy link

cla-bot bot commented Feb 6, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support other AuthTypes in addition to BasicAuth
1 participant