fix: make sure we sync a line when hitting esc while drawing #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I first tried to handle this on Leaflet.Editable side, to make it fire the "editable:edited" event we use to trigger the sync, but deciding what to do with a feature on escape needs some decisions that seems hard to implement in a generic way in Leaflet.Editable. We call stopDrawing, which then calls cancelDrawing, so here one need to decide if cancelDrawing should keep the already drawn line (but cancel the point being drawn) or cancel everything. This is why I end up making this change in uMap itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first tried to handle this on Leaflet.Editable side, to make it fire the "editable:edited" event we use to trigger the sync, but deciding what to do with a feature on escape needs some decisions that seems hard to implement in a generic way in Leaflet.Editable.
We call stopDrawing, which then calls cancelDrawing, so here one need to decide if cancelDrawing should keep the already drawn line (but cancel the point being drawn) or cancel everything.
This is why I end up making this change in uMap itself.