Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling Workflow Enhancement - Part 3 #101

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

kr11
Copy link
Collaborator

@kr11 kr11 commented Aug 28, 2024

Pull Request Description

This PR updates the PodAutoscaler workflow, enable to update the pod replicas based on the KPA algorithm.

In addition, it replaces the Deployment structure with Unstructured to increase flexibility.

For more details on why we're not using autoscalingv1.Scale, see issue #102

The README has been updated to demonstrate these changes.

Related Issues

Resolves: #102

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Aug 28, 2024

few minor changes. rest part looks good to me. @kr11 Great work!

@Jeffwan Jeffwan merged commit 9fa738e into main Aug 29, 2024
2 checks passed
@Jeffwan Jeffwan deleted the kangrong/features/autoscaling_workflow_part3 branch August 29, 2024 03:14
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Enable updating replicas based on KPA algorithm in PodAutoscaler

* fix PR review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion]: How to Obtain and Update Objects via Controller-Runtime
2 participants