BatchAPI storage component together with test #104
Conversation
| self._storage_type_name = "undefined" | ||
|
|
||
| @abstractmethod | ||
| def write_job_input_data(self, job_id, inputDataFileName): |
There was a problem hiding this comment.
do we need to write the job input data? should it be read-only?
There was a problem hiding this comment.
Yes it is read-only. This api is used to upload job's input data at the first place. After this upload, there is no need to write it.
There was a problem hiding this comment.
We can keep it here now. Let's have a discussion later on the "writing" part.
|
|
||
| @classmethod | ||
| def create_storage(cls, storage_type=0): | ||
| if storage_type == 0: |
There was a problem hiding this comment.
why do not we use some enum? int is not readable
|
|
||
| current_job_offsets = {} | ||
| job_input_requests = {} | ||
| p_storage = LocalDiskFiles() |
There was a problem hiding this comment.
I am ok for short term. it supposed to be a object wrapper for following methods. In the initialization, you can initialize the persist_storage.
| """ | ||
|
|
||
| def __init__(self): | ||
| self.directory_path = os.path.abspath(os.path.dirname(__file__)) |
There was a problem hiding this comment.
Should you create an env path instead of using the code path?
* support of batch storage and test * add repo version for setup * update print string format * update import format for isort * type annotation * ruff format * two formats * update variable name and remove setup script * add storage implmentation back * [CI] Remove isort check (#113) fix: remove isort check * use enum for storage type and env var * merge lock * update lock * format check --------- Signed-off-by: xinchen384 <[email protected]> Co-authored-by: xin.chen <[email protected]> Co-authored-by: brosoul <[email protected]>
Pull Request Description
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.