Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubeConfig redefined issue and update imagePullPolicy #158

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 10, 2024

Pull Request Description

  1. controller-manager failed to start due to redefined kubeconfig #157 describe the startup problem, controller-runtime already have kubeconfig defined.
  2. Since we use nightly image at this moment, it failed to load the new changes. Let's use Always for short term for testing. Once it's reliable, let's change back to IfNotPresent

Related Issues

Resolves: #157

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan merged commit b5c0443 into main Sep 10, 2024
3 checks passed
@Jeffwan Jeffwan deleted the jiaxin/resolve-release-blockers branch September 10, 2024 22:59
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Resolve the redefined kubeconfig issue

* Change ImagePullPolicy to Always for short term
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller-manager failed to start due to redefined kubeconfig
2 participants