Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users CRUD API #181

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Add users CRUD API #181

merged 7 commits into from
Sep 18, 2024

Conversation

varungup90
Copy link
Collaborator

No description provided.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 17, 2024

Seems the python testing script is flaky? This PR doesn't change any python code. @brosoul

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 18, 2024

Beside the container image, rest part looks good to me. feel free to merge it after dockerfile is updated.

@brosoul
Copy link
Collaborator

brosoul commented Sep 18, 2024

Seems the python testing script is flaky? This PR doesn't change any python code. @brosoul

@Jeffwan This looks like the pypi source is unstable, causing the fail of installing poetry. From the logs, it appears that the corresponding meta information for cryptography was not obtained, resulting in the use of a version that does not meet the dependency requirements, ultimately leading to the error.

I don't have any good workaround at the moment, just retry it 😂
image

@varungup90 varungup90 merged commit 38e2e71 into main Sep 18, 2024
4 checks passed
@varungup90 varungup90 deleted the add-users-api branch September 18, 2024 18:05
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add users CRUD API

* nit

* read userconfig in gateway plugin

* nit

* address code review comments

* revert dockerfile changes

---------

Co-authored-by: varungupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants