Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kuberay manifest as installation dependencies #203

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 23, 2024

Pull Request Description

Add kuberay manifest as installation dependencies

  1. Use helm template to generate manifests and repackage as kustomize package
  2. Remove third-party folder and refactor to use corresponding crds
  3. Update envoy gateway dependency folder structure

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: part of #161

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

1. Use helm template to generate manifests and repackage as kustomize package
2. Remove third-party folder and refactor to use corresponding crds
3. Update envoy gateway dependency folder structure
@Jeffwan Jeffwan force-pushed the jiaxin/kuberay-manifest branch from dc02a96 to c12eeea Compare September 23, 2024 18:33
@brosoul

This comment was marked as resolved.

@Jeffwan

This comment was marked as resolved.

@brosoul
Copy link
Collaborator

brosoul commented Sep 24, 2024

lgtm

@Jeffwan Jeffwan merged commit a9ed7c9 into main Sep 24, 2024
7 checks passed
@Jeffwan Jeffwan deleted the jiaxin/kuberay-manifest branch September 24, 2024 05:13
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add kuberay manifest as installation dependencies

1. Use helm template to generate manifests and repackage as kustomize package
2. Remove third-party folder and refactor to use corresponding crds
3. Update envoy gateway dependency folder structure

* Move resources files under templates folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants