Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] add Runtime dependency for hf_transfer #240

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

brosoul
Copy link
Collaborator

@brosoul brosoul commented Sep 26, 2024

Pull Request Description

poetry add hf_transfer
After executing export HF_HUB_ENABLE_HF_TRANSFER=1 , the issue #211 can be stably reproduced.
img_v3_02f3_0bfd2e25-181c-4179-ad3e-3296861b445g

After install hf_transfer, the issue could be resolved.
2890131f-9a2a-4408-aff8-67002f99ec6e

Related Issues

Resolves: #211

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 26, 2024

I didn't explicitly set export HF_HUB_ENABLE_HF_TRANSFER=1, do you know hits is enabled?

@Jeffwan Jeffwan merged commit 39ffbb9 into main Sep 26, 2024
10 checks passed
@Jeffwan Jeffwan deleted the linhui/runtime_hf_dependency branch September 26, 2024 17:20
@brosoul
Copy link
Collaborator Author

brosoul commented Sep 27, 2024

I didn't explicitly set export HF_HUB_ENABLE_HF_TRANSFER=1, do you know hits is enabled?
@Jeffwan
I have tried downloading from HunggingFace multiple times without triggering this error. Only triggered after setting export HF_HUB_ENABLE_HF_TRANSFER=1

gangmuk pushed a commit that referenced this pull request Jan 25, 2025
misc: add dependency for hf_transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aibrix downloader failed due to No module named 'hf_transfer'
2 participants