Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the routing env value & flag retrieval #373

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Nov 12, 2024

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #368

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan requested a review from varungup90 November 12, 2024 00:53
@Jeffwan Jeffwan force-pushed the jiaxin/update-routing branch from b56e5f6 to 5b211fe Compare November 12, 2024 00:56
@Jeffwan Jeffwan merged commit 2e0179c into main Nov 12, 2024
9 checks passed
@Jeffwan Jeffwan deleted the jiaxin/update-routing branch November 12, 2024 01:16
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add more debug information from input side

* Add the utils to get routing value & enabled part

* Update the unit tests

* Fix the lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to make requests if metrics endpoint is not available
2 participants